Skip to content

Fix 'Install dependencies' links #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 29, 2024

Fixes #1275.

Before

https://devguide.python.org/#quick-reference says:

See also more detailed instructions, how to install and build dependencies, and the platform-specific pages for Unix, Install dependencies, and Windows.

https://devguide.python.org/getting-started/setup-building/#macos says:

This section explains how to install additional extensions (e.g. zlib) on Linux and Install dependencies.

After

They say:

See also more detailed instructions, how to install and build dependencies, and the platform-specific pages for Unix, macOS, and Windows.

And:

This section explains how to install additional extensions (e.g. zlib) on Linux and macOS.


📚 Documentation preview 📚: https://cpython-devguide--1282.org.readthedocs.build/

@@ -455,7 +455,7 @@ Install dependencies
====================

This section explains how to install additional extensions (e.g. ``zlib``)
on :ref:`Linux <deps-on-linux>` and :ref:`macOS`.
on Linux and macOS.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these links no longer needed due to the introduction of OS-specific tabs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the targets are just above this header, so there's no point linking to the current location.

@hugovk hugovk merged commit 49d823f into python:main Mar 3, 2024
@hugovk hugovk deleted the fix-macos-links branch March 3, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"macOS" links say "Install dependencies"
2 participants