Skip to content

Add inline tabs on Helping with the Developer’s Guide page for commands on different systems #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2023

Conversation

lancegoyke
Copy link
Contributor

@lancegoyke lancegoyke commented Nov 18, 2023

Hey again team! I was hoping to knock a few more of these out this weekend.

This PR should close a single TODO in #1196.

I did restructure the writing a bit to break up the directive "to build the devguide..." from the long paragraph before it.


📚 Documentation preview 📚: https://cpython-devguide--1223.org.readthedocs.build/documentation/devguide/

@hugovk
Copy link
Member

hugovk commented Nov 18, 2023

Hello! Thanks again for these!

We've also since added some JavaScript to activate the relevant tab based on the browser's operating system in #1216.

Like in that PR, please could you add this snippet near the top of the new pages with tabs?

.. raw:: html

    <script>
    document.addEventListener('DOMContentLoaded', function() {
      activateTab(getOS());
    });
    </script>

@lancegoyke
Copy link
Contributor Author

Of course! Apologies, I had seen you mention that, but I missed the fact that it needed to be included on each page.

@hugovk
Copy link
Member

hugovk commented Nov 18, 2023

No apology needed! Yeah, we could have loaded the JS for all pages, but for now we went with explicitly adding it to the tab pages.

On reflection, it's such a small amount of JS it's probably fine to always load it, but we can think about that later.

Anyway, I think we could also combine the Unix and macOS tabs in this one into a single Unix/macOS tab?

@lancegoyke
Copy link
Contributor Author

Sounds good to me!

@hugovk hugovk merged commit 20979d9 into python:main Nov 19, 2023
@hugovk
Copy link
Member

hugovk commented Nov 19, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants