Skip to content

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Dec 9, 2022

For #681.

  • Group linkcheck_* configs together
  • Update linkcheck_ignore rules
  • Add linkcheck_allowed_redirects rules
  • Update new PSF link redirect

Linkcheck docs: https://www.sphinx-doc.org/en/master/usage/configuration.html#options-for-the-linkcheck-builder

After this (and #1001 and #1002), all that fails with make linkcheck are the four tracked in #1003.

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hugovk

@hugovk hugovk merged commit adc6491 into python:main Dec 11, 2022
@hugovk hugovk deleted the fix-linkcheck branch December 11, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants