Skip to content

gh-78453: Move Unicode C API tests from test_unicode to test_capi.test_unicode #99431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2022
Merged

gh-78453: Move Unicode C API tests from test_unicode to test_capi.test_unicode #99431

merged 1 commit into from
Nov 14, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 13, 2022 •
edited by bedevere-bot
Loading

It is a prerequisite to adding much more tests.

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 13, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 13, 2022
Closed
gpshead
gpshead approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to backport this test move refactoring, add a news entry. If it's for main only, skip news is fine.

@serhiy-storchaka
Copy link
Member Author

The news entry for #8551 is general enough and covers this change.

@serhiy-storchaka serhiy-storchaka merged commit 06d4e02 into python:main Nov 14, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 06d4e02c3b3526b5d90e41a0a0befa8663e08f27 3.11

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 06d4e02c3b3526b5d90e41a0a0befa8663e08f27 3.10

@serhiy-storchaka serhiy-storchaka deleted the test_capi-unicode branch November 15, 2022 06:19
@bedevere-bot
Copy link

GH-99614 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 20, 2022
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Nov 20, 2022
@serhiy-storchaka
[3.11] pythongh-78453: Move Unicode C API tests from test_unicode to …
e72dbec 
…test_capi.test_unicode (pythonGH-99431).

(cherry picked from commit 06d4e02)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Nov 20, 2022
@serhiy-storchaka
[3.11] gh-78453: Move Unicode C API tests from test_unicode to test_c…
56a517e 
…api.test_unicode (GH-99431). (GH-99614)

(cherry picked from commit 06d4e02)
@bedevere-bot
Copy link

GH-99617 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 20, 2022
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Nov 20, 2022
@serhiy-storchaka
[3.10] pythongh-78453: Move Unicode C API tests from test_unicode to …
3eca307 
…test_capi.test_unicode (pythonGH-99431).

(cherry picked from commit 06d4e02)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Nov 20, 2022
@serhiy-storchaka
[3.10] gh-78453: Move Unicode C API tests from test_unicode to test_c…
42b7b21 
…api.test_unicode (GH-99431). (GH-99617)

(cherry picked from commit 06d4e02)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka removed their assignment Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @miss-islington @bedevere-bot @gpshead