gh-98500: Fix typing docs for *View classes
#98511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested review from
gvanrossum,
Fidget-Spinner,
JelleZijlstra and
AlexWaygood
as code owners
Doc/library/typing.rst
Outdated
| @@ -2096,15 +2096,15 @@ Corresponding to collections in :mod:`collections.abc` | |||
| :class:`collections.abc.Container` now supports ``[]``. See :pep:`585` | |||
| and :ref:`types-genericalias`. | |||
|
|
|||
| .. class:: ItemsView(MappingView, Generic[KT_co, VT_co]) | |||
| .. class:: ItemsView(MappingView, AbstractSet[tuple[KT_co, VT_co]], Generic[KT_co, VT_co]) | |||
There was a problem hiding this comment.
Generic is redundant as a base class, because there is a generic base. Other classes nearby don't list Generic as an explicit base, so these ones shouldn't either.
There was a problem hiding this comment.
Yes, I feel like the fact that so many typeshed classes do this in the stubs is something of a legacy thing (though some may prefer it for added explicitness).
JelleZijlstra
approved these changes
Oct 24, 2022
JelleZijlstra
added
needs backport to 3.10
|
Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-98611 is a backport of this pull request to the 3.11 branch. |
|
GH-98612 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 24, 2022
(cherry picked from commit 1a217f9) Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 24, 2022
(cherry picked from commit 1a217f9) Co-authored-by: Nikita Sobolev <[email protected]>
|
Thank you! I've noticed some other docs-related problems. Will do later this week. |
miss-islington
added a commit
that referenced
this pull request
Oct 24, 2022
(cherry picked from commit 1a217f9) Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 24, 2022
(cherry picked from commit 1a217f9) Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typing.MappingViewandtyping.ItemsViewon several versions of CPython #98500