-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
collections.abc.ValuesView
is not sufficently tested
#98512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
sobolevn
added a commit
to sobolevn/cpython
that referenced
this issue
Oct 21, 2022
JelleZijlstra
pushed a commit
that referenced
this issue
Nov 3, 2022
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Nov 3, 2022
(cherry picked from commit 29e027c) Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Nov 3, 2022
(cherry picked from commit 29e027c) Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington
added a commit
that referenced
this issue
Nov 3, 2022
(cherry picked from commit 29e027c) Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington
added a commit
that referenced
this issue
Nov 3, 2022
(cherry picked from commit 29e027c) Co-authored-by: Nikita Sobolev <[email protected]>
Thanks, looks like this is completed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are places where it is either not complete:
cpython/Lib/test/test_dictviews.py
Lines 338 to 340 in 49f6106
Not base classes are covered here. But, I guess it should be.
Or there are places where it is not tested at all:
cpython/Lib/test/test_collections.py
Lines 1866 to 1869 in 49f6106
I will go through places like this and cover
ValuesView
.Noticed while working on #98511
ValuesView
(GH-98515) #99035ValuesView
(GH-98515) #99036The text was updated successfully, but these errors were encountered: