Skip to content

GH-85760: Fix race in calling process_exited callback too early #97009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2022
Merged

GH-85760: Fix race in calling process_exited callback too early #97009

merged 2 commits into from
Sep 22, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Sep 22, 2022 •
edited by bedevere-bot
Loading

@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error topic-asyncio labels Sep 22, 2022
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 22, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit fda5f3d 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 22, 2022
@gvanrossum gvanrossum merged commit 282edd7 into python:main Sep 22, 2022
@kumaraditya303 kumaraditya303 deleted the asyncio-subprocess-race branch September 22, 2022 16:58
@kumaraditya303 kumaraditya303 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Sep 22, 2022
@miss-islington
Copy link
Contributor

Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @kumaraditya303 and @gvanrossum, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 282edd7b2a74c4dfe1bfe3c5b1d30f9c21d554d6 3.11

@bedevere-bot
Copy link

GH-97023 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 22, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2022
@kumaraditya303 @miss-islington
pythonGH-85760: Fix race in calling process_exited callback too early (…
ed3f0be 
…pythonGH-97009)

(cherry picked from commit 282edd7)

Co-authored-by: Kumar Aditya <[email protected]>
@kumaraditya303 kumaraditya303 added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Sep 22, 2022
@miss-islington
Copy link
Contributor

Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2022
@kumaraditya303 @miss-islington
pythonGH-85760: Fix race in calling process_exited callback too early (…
d994837 
…pythonGH-97009)

(cherry picked from commit 282edd7)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 22, 2022
@bedevere-bot
Copy link

GH-97024 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request Sep 22, 2022
@miss-islington @kumaraditya303
GH-85760: Fix race in calling process_exited callback too early (GH-9…
43d8860 
…7009)

(cherry picked from commit 282edd7)

Co-authored-by: Kumar Aditya <[email protected]>
miss-islington added a commit that referenced this pull request Sep 22, 2022
@miss-islington @kumaraditya303
GH-85760: Fix race in calling process_exited callback too early (GH-9…
6642d8a 
…7009)

(cherry picked from commit 282edd7)

Co-authored-by: Kumar Aditya <[email protected]>
@kumaraditya303 kumaraditya303 mentioned this pull request Sep 22, 2022
Closed
@sorcio sorcio mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

@gvanrossum gvanrossum

Labels
topic-asyncio type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kumaraditya303 @bedevere-bot @miss-islington @gvanrossum