Skip to content

gh-96917: link to typing.readthedocs.io from typing.rst #96921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Sep 18, 2022

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want me to merge it right now? How about a backport to 3.11?

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvanrossum gvanrossum merged commit 5b3a256 into python:main Sep 19, 2022
@miss-islington
Copy link
Contributor

Thanks @hauntsaninja for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 19, 2022
@miss-islington
Copy link
Contributor

Sorry, @hauntsaninja and @gvanrossum, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5b3a2569f4b4dfb58a8f90a241f9dac1a7ea4bf6 3.10

@bedevere-bot
Copy link

GH-96936 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 19, 2022
…GH-96921)

See the discussion at python#91533
(cherry picked from commit 5b3a256)

Co-authored-by: Shantanu <[email protected]>
@hauntsaninja
Copy link
Contributor Author

I can do the 3.10 backport

hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request Sep 19, 2022
hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request Sep 19, 2022
…ythonGH-96921)

See the discussion at python#91533.
(cherry picked from commit 5b3a256)

Co-authored-by: Shantanu <[email protected]>
hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request Sep 19, 2022
…ythonGH-96921)

See the discussion at python#91533.
(cherry picked from commit 5b3a256)

Co-authored-by: Shantanu <[email protected]>
@bedevere-bot
Copy link

GH-96937 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 19, 2022
@hauntsaninja hauntsaninja deleted the gh96917 branch September 19, 2022 19:13
miss-islington added a commit that referenced this pull request Sep 19, 2022
See the discussion at #91533
(cherry picked from commit 5b3a256)

Co-authored-by: Shantanu <[email protected]>
Fidget-Spinner pushed a commit that referenced this pull request Sep 20, 2022
) (GH-96937)

See the discussion at #91533.
(cherry picked from commit 5b3a256)

Co-authored-by: Shantanu <[email protected]>
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
See the discussion at #91533
(cherry picked from commit 5b3a256)

Co-authored-by: Shantanu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants