Skip to content

gh-95280: Fix test_get_ciphers on systems without RSA key exchange (GH-95282) #95282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2022
Merged

gh-95280: Fix test_get_ciphers on systems without RSA key exchange (GH-95282) #95282

merged 1 commit into from
Jul 27, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jul 26, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jul 26, 2022
@tiran tiran added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jul 26, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 63d60d0 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 26, 2022
@tiran tiran changed the title gh-95280: Fix test_get_ciphers on systems without RSA key exchange gh-95280: Fix test_get_ciphers on systems without RSA key exchange (GH-95282) Jul 27, 2022
@tiran tiran merged commit 5654030 into python:main Jul 27, 2022
@tiran tiran deleted the gh-95280-ciphers-pfs branch July 27, 2022 07:19
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @tiran, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 565403038b75eb64ea483b2757ba30769246d853 3.11

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 27, 2022
@bedevere-bot
Copy link

GH-95309 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2022
@tiran @miss-islington
pythongh-95280: Fix test_get_ciphers on systems without RSA key excha…
3ccbf41 
…nge (pythonGH-95282)

(cherry picked from commit 5654030)

Co-authored-by: Christian Heimes <[email protected]>
@tiran tiran added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jul 27, 2022
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2022
@tiran @miss-islington
pythongh-95280: Fix test_get_ciphers on systems without RSA key excha…
75e7707 
…nge (pythonGH-95282)

(cherry picked from commit 5654030)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot
Copy link

GH-95310 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 27, 2022
miss-islington added a commit that referenced this pull request Jul 27, 2022
@miss-islington @tiran
gh-95280: Fix test_get_ciphers on systems without RSA key exchange (G…
b77c403 
…H-95282)

(cherry picked from commit 5654030)

Co-authored-by: Christian Heimes <[email protected]>
tiran added a commit that referenced this pull request Jul 27, 2022
@miss-islington @tiran
[3.11] gh-95280: Fix test_get_ciphers on systems without RSA key exch…
131fc72 
…ange (GH-95282) (GH-95310)

Co-authored-by: Christian Heimes <[email protected]>
@frenzymadness frenzymadness mentioned this pull request Jul 27, 2022
Closed
@stratakis
Copy link
Contributor

@ambv are you ok with backporting that to 3.9? This affect the CentOS Stream 9 FIPS enabled buildbot and it's a tests only fix.

@tiran tiran added 3.9 only security fixes and removed 3.9 only security fixes labels Jul 27, 2022
@tiran tiran added the needs backport to 3.9 only security fixes label Jul 27, 2022
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2022
@tiran @miss-islington
pythongh-95280: Fix test_get_ciphers on systems without RSA key excha…
bea2e58 
…nge (pythonGH-95282)

(cherry picked from commit 5654030)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 27, 2022
@bedevere-bot
Copy link

GH-95323 is a backport of this pull request to the 3.9 branch.

@tiran
Copy link
Member Author

tiran commented Jul 27, 2022

backport applies cleanly to 3.9.

ambv pushed a commit that referenced this pull request Jul 29, 2022
@miss-islington @tiran
gh-95280: Fix test_get_ciphers on systems without RSA key exchange (G…
03dc951 
…H-95282) (GH-95323)

(cherry picked from commit 5654030)

Co-authored-by: Christian Heimes <[email protected]>
@ambv
Copy link
Contributor

ambv commented Jul 29, 2022

Landed in 3.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tiran tiran

Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiran @bedevere-bot @miss-islington @stratakis @ambv