[3.11] gh-95174: Handle missing dup() and constants in WASI (GH-95229) (GH-95272) #95272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a large-ish change. @pablogsal, you press the green button. |
pablogsal
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit c988300e24cfdc235b343a9ab4f2ec7a2a917d44 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
@pablogsal are you ok with this changeset? It only affects wasm32-wasi builds. The two test failures are unrelated. |
…thonGH-95229) - check for ``dup()`` libc function - handle missing ``F_DUPFD`` in ``dup2()`` replacement function - add workaround for WASI libc bug in MSG_TRUNC - ESHUTDOWN is missing, use EPIPE instead - POLLPRI is missing, define as 0 (no-op). (cherry picked from commit 0d35a59) Co-authored-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
backport-0d35a59-3.11
branch
from
c988300 to
dfdb0d3
Compare
|
Rebased on latest 3.11, fixed a conflict in auto-generated files. |
tiran
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
pablogsal
approved these changes
Jul 31, 2022
pablogsal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dup()libc functionF_DUPFDindup2()replacement function(cherry picked from commit 0d35a59)
Co-authored-by: Christian Heimes [email protected]