GH-94036: Fix more attribute location quirks #95028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtbucher
added
type-bug
|
LGTM |
iritkatriel
approved these changes
Jul 22, 2022
|
Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry, @brandtbucher, I could not cleanly backport this to |
brandtbucher
added a commit
to brandtbucher/cpython
that referenced
this pull request
Jul 23, 2022
…5028). (cherry picked from commit 900bfc5) Co-authored-by: Brandt Bucher <[email protected]>
|
GH-95156 is a backport of this pull request to the 3.11 branch. |
brandtbucher
added a commit
that referenced
this pull request
Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several quirks in the location info generated for multiline attribute accesses and method calls:
Attributenodes. Many of these did not bother with updating column offsets, and could produce nonsensical ranges as a result.update_location_to_match_attrto leave end location info alone (so that things like method calls have correct spans), and renames it toupdate_start_location_to_match_attrto reflect this.pytest-like ASTs that nevertheless have valid locations for each node.