Skip to content

GH-94254: make _struct module types immutable #94269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 26, 2022
Merged

GH-94254: make _struct module types immutable #94269

merged 5 commits into from
Jun 26, 2022

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jun 25, 2022 •
edited by bedevere-bot
Loading

@kumaraditya303 kumaraditya303 added needs backport to 3.10 only security fixes extension-modules C modules in the Modules dir needs backport to 3.11 only security fixes labels Jun 25, 2022
erlend-aasland
erlend-aasland requested changes Jun 25, 2022
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented Jun 25, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland erlend-aasland merged commit 17ed560 into python:main Jun 26, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Jun 26, 2022

Thanks @kumaraditya303 for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2022
@kumaraditya303 @miss-islington
pythonGH-94254: Make _struct module types immutable (pythonGH-94269)
bd0a261 
(cherry picked from commit 17ed560)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 26, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jun 26, 2022

GH-94294 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2022
@kumaraditya303 @miss-islington
pythonGH-94254: Make _struct module types immutable (pythonGH-94269)
f0db306 
(cherry picked from commit 17ed560)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Jun 26, 2022

GH-94295 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 26, 2022
@kumaraditya303 kumaraditya303 deleted the immutable branch June 26, 2022 10:17
@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Jun 26, 2022

Thanks @erlend-aasland

miss-islington added a commit that referenced this pull request Jun 26, 2022
@miss-islington @kumaraditya303
GH-94254: Make _struct module types immutable (GH-94269)
5ce819f 
(cherry picked from commit 17ed560)

Co-authored-by: Kumar Aditya <[email protected]>
miss-islington added a commit that referenced this pull request Jun 26, 2022
@miss-islington @kumaraditya303
GH-94254: Make _struct module types immutable (GH-94269)
c481cd6 
(cherry picked from commit 17ed560)

Co-authored-by: Kumar Aditya <[email protected]>
@kumaraditya303 kumaraditya303 mentioned this pull request Jun 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

extension-modules C modules in the Modules dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumaraditya303 @bedevere-bot @miss-islington @erlend-aasland