test_concurrent_futures: Remove unneeded/confusing format call #93119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in 339fd46 - but as noted in a comment, the test only tests ThreadPoolExecutor.
DanielNoord
approved these changes
Jul 7, 2022
kumaraditya303
approved these changes
Jul 7, 2022
JelleZijlstra
added
needs backport to 3.10
|
Thanks @The-Compiler for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 19, 2022
…-93119) Added in 339fd46 - but as noted in a comment, the test only tests ThreadPoolExecutor. (cherry picked from commit 3f2dd0a) Co-authored-by: Florian Bruhin <[email protected]>
|
GH-94993 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 19, 2022
…-93119) Added in 339fd46 - but as noted in a comment, the test only tests ThreadPoolExecutor. (cherry picked from commit 3f2dd0a) Co-authored-by: Florian Bruhin <[email protected]>
|
GH-94994 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Jul 19, 2022
Added in 339fd46 - but as noted in a comment, the test only tests ThreadPoolExecutor. (cherry picked from commit 3f2dd0a) Co-authored-by: Florian Bruhin <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jul 19, 2022
Added in 339fd46 - but as noted in a comment, the test only tests ThreadPoolExecutor. (cherry picked from commit 3f2dd0a) Co-authored-by: Florian Bruhin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in 339fd46 (GH-18057) by @aeros - but as noted in a comment, the test only tests ThreadPoolExecutor. Thus, I'm assuming that was a copy-paste mistake.
I believe this is simple enough to not need an issue/news entry.
(Found by running
flake8overLib/out of curiosity, see #93010 (comment))