Improve tests for opening Sqlite by URI #93047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serhiy-storchaka
commented
May 21, 2022
serhiy-storchaka
commented
- Test with with escaped non-ascii characters
- Test read-only open of existing DB.
* Test with with escaped non-ascii characters * Test read-only open of existing DB.
serhiy-storchaka
added
tests
serhiy-storchaka
requested review from
berkerpeksag and
erlend-aasland
as code owners
erlend-aasland
approved these changes
May 21, 2022
| uri = "file:" + urllib.parse.quote(path) | ||
| self.assertFalse(os.path.exists(path)) | ||
| try: | ||
| with managed_connect(uri, uri=True, in_mem=True) as cx: |
There was a problem hiding this comment.
I see the in_mem param is ill named. We can revisit this helper function in another PR.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-93051 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2022
* Test with with escaped non-ascii characters * Test read-only open of existing DB. (cherry picked from commit 4e2b664) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 21, 2022
* Test with with escaped non-ascii characters * Test read-only open of existing DB. (cherry picked from commit 4e2b664) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.