Skip to content

gh-92118: fix traceback of exceptions propagated from inside a contextlib.contextmanager #92202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 4, 2022
Merged

gh-92118: fix traceback of exceptions propagated from inside a contextlib.contextmanager #92202

merged 4 commits into from
May 4, 2022

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented May 2, 2022 •
edited by serhiy-storchaka
Loading

@iritkatriel iritkatriel requested a review from 1st1 as a code owner May 2, 2022 23:00
@iritkatriel iritkatriel mentioned this pull request May 2, 2022
Closed
hauntsaninja
hauntsaninja reviewed May 2, 2022
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! I think we might need to do this in the RuntimeError except clause as well.

@Zac-HD Zac-HD mentioned this pull request May 3, 2022
Closed
gvanrossum
gvanrossum approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a thing.

serhiy-storchaka
serhiy-storchaka reviewed May 3, 2022
View reviewed changes
@AlexWaygood AlexWaygood added the stdlib Standard Library Python modules in the Lib/ directory label May 4, 2022
@iritkatriel iritkatriel merged commit e61330b into python:main May 4, 2022
@iritkatriel iritkatriel deleted the gh-92118 branch May 4, 2022 18:40
This was referenced May 11, 2022
Closed
Merged
@mattclay mattclay mentioned this pull request Nov 28, 2022
Open
Eta0 referenced this pull request in coreweave/tensorizer Dec 8, 2023
@Eta0
feat(crypt): Add fast encryption
a2cd158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@hauntsaninja hauntsaninja hauntsaninja left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@markshannon markshannon Awaiting requested review from markshannon

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@iritkatriel @gvanrossum @serhiy-storchaka @hauntsaninja @bedevere-bot @AlexWaygood