Skip to content

gh-84459: Make wording more specific for Path.replace #91853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

slateny
Copy link
Contributor

@slateny slateny commented Apr 23, 2022

#84459

Automerge-Triggered-By: GH:brettcannon

@slateny slateny requested a review from brettcannon as a code owner April 23, 2022 07:47
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 23, 2022
@brettcannon
Copy link
Member

/cc @barneygale

@slateny slateny changed the title gh-84459: Made wording more specific for Path.replace gh-84459: Make wording more specific for Path.replace Apr 26, 2022
Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also correct the docs for os.replace()? They're wrong in a slightly different way. Otherwise LGTM.

@slateny
Copy link
Contributor Author

slateny commented Apr 27, 2022

Used non-empty over nonempty as it seemed more common

@miss-islington
Copy link
Contributor

Thanks @slateny for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @slateny for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 27, 2022
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Apr 27, 2022
@bedevere-bot
Copy link

GH-92002 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 27, 2022
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Apr 27, 2022
@bedevere-bot
Copy link

GH-92003 is a backport of this pull request to the 3.10 branch.

@brettcannon
Copy link
Member

Thanks!

miss-islington added a commit that referenced this pull request Apr 27, 2022
miss-islington added a commit that referenced this pull request Apr 27, 2022
@slateny slateny deleted the s/pathlib branch April 28, 2022 07:34
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants