-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-84459: Make wording more specific for Path.replace #91853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/cc @barneygale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also correct the docs for os.replace()
? They're wrong in a slightly different way. Otherwise LGTM.
Used |
Thanks @slateny for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Thanks @slateny for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
…-91853) pythonGH-84459 (cherry picked from commit 161dff7) Co-authored-by: slateny <[email protected]>
GH-92002 is a backport of this pull request to the 3.9 branch. |
…-91853) pythonGH-84459 (cherry picked from commit 161dff7) Co-authored-by: slateny <[email protected]>
GH-92003 is a backport of this pull request to the 3.10 branch. |
Thanks! |
GH-84459 (cherry picked from commit 161dff7) Co-authored-by: slateny <[email protected]>
GH-84459 (cherry picked from commit 161dff7) Co-authored-by: slateny <[email protected]>
…-91853) pythonGH-84459 (cherry picked from commit 161dff7) Co-authored-by: slateny <[email protected]>
#84459
Automerge-Triggered-By: GH:brettcannon