Skip to content

bpo-34569: Fix subinterpreter 32-bit ABI, pystate.c/_new_long_object() #9127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 11, 2019
Merged

bpo-34569: Fix subinterpreter 32-bit ABI, pystate.c/_new_long_object() #9127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
70f0c39
Modify DEFAULT_CONFIG for AIX
aixtools Sep 4, 2018
1fb1c88
bedevere/news did not like old name
aixtools Sep 4, 2018
cc96bef
For AIX, when ABI == 32-bit, Skip value (-1) in `test__xxsubinterpret…
aixtools Sep 9, 2018
20a4c4c
Move the test for better performance and to prevent type mispatch
aixtools Sep 10, 2018
79a9475
Modified per peer review: use sys.maxsize to determine 32-bit or 64-bit;
aixtools Sep 13, 2018
9b3a30d
modify NEWS
aixtools Sep 18, 2018
3868e4d
Fix pystate.c/_new_long_object when ULONG_MAX==UINT_MAX
aixtools Oct 11, 2018
ddaa61b
remove spurious comments
aixtools Oct 11, 2018
1d5d51e
remove spurious edits
aixtools Oct 16, 2018
88d4686
Use capital letter as first character
aixtools Oct 23, 2018
c5bdbca
Fix pystate.c/_new_long_object() by using intptr_t type cast
aixtools Nov 10, 2018
a607a12
Restore blank lines to test
aixtools Nov 11, 2018
71de18a
Reword NEWS entry
ncoghlan Dec 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Tests/2018-09-09-14-36-59.bpo-34569.okj1Xh.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The experimental PEP 554 data channels now correctly pass negative PyLong
objects between subinterpreters on 32-bit systems. Patch by Michael Felt.
2 changes: 1 addition & 1 deletion Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1426,7 +1426,7 @@ _str_shared(PyObject *obj, _PyCrossInterpreterData *data)
static PyObject *
_new_long_object(_PyCrossInterpreterData *data)
{
return PyLong_FromLongLong((int64_t)(data->data));
return PyLong_FromLongLong((intptr_t)(data->data));
}

static int
Expand Down