[2.7] bpo-34457: Python/ast.c: Add missing NULL check to alias_for_im… #8858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port_name(). (pythonGH-8852) Reported by Svace static analyzer.. (cherry picked from commit 28853a2) Co-authored-by: Alexey Izbyshev <[email protected]>
bedevere-bot
added
skip news
type-bug
serhiy-storchaka
approved these changes
Aug 22, 2018
eamanu
reviewed
Aug 22, 2018
| @@ -2520,6 +2520,8 @@ alias_for_import_name(struct compiling *c, const node *n, int store) | |||
| break; | |||
| case STAR: | |||
| str = PyString_InternFromString("*"); | |||
| if (!str) | |||
There was a problem hiding this comment.
In which case the if sentence could fail?
There was a problem hiding this comment.
In an unlikely case of one-character-string cache miss combined with memory allocation failure.
eamanu
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…port_name(). (GH-8852)
Reported by Svace static analyzer..
(cherry picked from commit 28853a2)
Co-authored-by: Alexey Izbyshev [email protected]
https://bugs.python.org/issue34457