Skip to content

gh-68443: Replace debug level-related logic in http client with logging #8633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
CuriousLearner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-68443: Replace debug level-related logic in http client with logging #8633

CuriousLearner wants to merge 1 commit into from

Conversation

@CuriousLearner
Copy link
Member

@CuriousLearner CuriousLearner commented Aug 2, 2018 •
edited by bedevere-app bot
Loading

@CuriousLearner
Copy link
Member Author

CuriousLearner commented Aug 7, 2018 •
edited
Loading

@vsajip Hello, I see that there are various linting errors in test_logging.py which were fixed in 5f63c20. Does it make sense to separate them out in another Pull Request?

@willingc willingc self-requested a review October 7, 2018 09:23
@CuriousLearner
Copy link
Member Author

CuriousLearner commented May 9, 2019

Hey @bitdancer , @vsajip

Can you please have a look at this? I just noticed this PR wasn't reviewed from almost a year. Please let me know, what is needed here.

Thanks!

@willingc
Copy link
Contributor

willingc commented May 9, 2019

@CuriousLearner I would go ahead and rebase to resolve conflicts.

@CuriousLearner
Copy link
Member Author

CuriousLearner commented May 11, 2019

@willingc Done!

dhilst
dhilst reviewed Jun 21, 2019
View reviewed changes
Lib/http/client.py Outdated
raise LineTooLong("status line")
if self.debuglevel > 0:
print("reply:", repr(line))
_log.info("reply: {}".format(repr(line)))
Copy link

@dhilst dhilst Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logging first argument support old format string, so _log.info("reply: %s", repr(line)) would work. There is mixed calls of {}".format(foo with %s", foo, wouldn't be better to stick with one?

Copy link
Member

@vsajip vsajip Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't be better to stick with one?

I agree - % should work fine and a lot of logging uses %-formatting rather than .format() due to its age.

Copy link
Contributor

@asvetlov asvetlov Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another reason: tools like Sentry use message pattern as a key for logs grouping.
Adding pre-formatted messages to Sentry is very ineffective.

Copy link
Member Author

@CuriousLearner CuriousLearner Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry!

I think I came back to this later and followed the same style as for other Python projects I was involved with.

Fixing this!

dhilst
dhilst reviewed Jun 21, 2019
View reviewed changes
Lib/test/test_httplib.py Outdated
import io
import itertools
import os
import sys
Copy link

@dhilst dhilst Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't being used anywhere!?

Copy link
Member Author

@CuriousLearner CuriousLearner Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good catch. I think it remained here while I was working on this.

vsajip
vsajip reviewed Jun 21, 2019
View reviewed changes
Lib/test/test_logging.py Outdated
logger = logging.getLogger("http")
root_logger = self.root_logger
root_logger.removeHandler(self.root_logger.handlers[0])
logger = logging.getLogger("httplogger")
Copy link
Member

@vsajip vsajip Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this name change?

Copy link
Member Author

@CuriousLearner CuriousLearner Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no specific reason for it. I'll just revert back.

@csabella csabella requested a review from bitdancer February 25, 2020 12:34
@demianbrecht demianbrecht mannequin mentioned this pull request Apr 10, 2022
Open
@github-actions
Copy link

github-actions bot commented Dec 15, 2024

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 15, 2024
@picnixz picnixz changed the title bpo-24255: Replace debug level-related logic in http client with logging gh-68443: Replace debug level-related logic in http client with logging Dec 15, 2024
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Feb 27, 2025
@github-actions
Copy link

github-actions bot commented Apr 13, 2025

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Apr 13, 2025
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 18, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Apr 18, 2025
@github-actions
Copy link

github-actions bot commented Jun 15, 2025

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 15, 2025
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Oct 12, 2025
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Nov 11, 2025
@CuriousLearner CuriousLearner removed the stale Stale PR or inactive for long period of time. label Nov 14, 2025
@CuriousLearner
bpo-24255: Replace debug prints with logging in http.client
afeb73c 
Replace debuglevel-based print statements with Python's standard
logging module for better integration with logging frameworks and
log aggregation tools like Sentry. Uses % formatting consistently
for better log pattern matching in aggregation tools.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc Awaiting requested review from willingc

@bitdancer bitdancer Awaiting requested review from bitdancer

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov

@dhilst dhilst Awaiting requested review from dhilst

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@CuriousLearner @willingc @vsajip @asvetlov @dhilst @the-knights-who-say-ni @ezio-melotti @bedevere-bot