Skip to content

bpo-31047: Fix ntpath.abspath for invalid paths #8544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 29, 2018

Conversation

mansenfranzen
Copy link
Contributor

@mansenfranzen mansenfranzen commented Jul 29, 2018

Fixes nt.abspath for invalid paths to ensure os.path.isabs(os.path.abspath(" ")) == True to behave the same as for "" or "?".

Refers to https://bugs.python.org/issue31047

Co-authored-by:

https://bugs.python.org/issue31047

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

You can check yourself
to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need the NEWS entry - click on the "Details" link for the failed check for info on how to add it. (Your PR title is a good description to put in there.)

@mansenfranzen
Copy link
Contributor Author

Thanks for the advice - added the news entry accordingly.

@zooba zooba merged commit d2e902e into python:master Jul 29, 2018
@miss-islington
Copy link
Contributor

Thanks @mansenfranzen for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-8549 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2018
(cherry picked from commit d2e902e)

Co-authored-by: Franz Wöllert <[email protected]>
@miss-islington
Copy link
Contributor

Sorry, @mansenfranzen and @zooba, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d2e902e4fb304f27e4a72356efbc1fc26be3935d 3.6

@bedevere-bot
Copy link

GH-8550 is a backport of this pull request to the 3.6 branch.

@zooba
Copy link
Member

zooba commented Jul 29, 2018

@mansenfranzen I'm assuming you are/were here at the EuroPython sprints and submitted the CLA form already, yes?

In any case, the code in the change matches what was provided on the issue tracker by someone who definitely has submitted it, which is why I merged already.

@mansenfranzen
Copy link
Contributor Author

Yes, filled in the CLA form already.

@zooba zooba added the sprint label Jul 29, 2018
miss-islington added a commit that referenced this pull request Jul 29, 2018
(cherry picked from commit d2e902e)

Co-authored-by: Franz Wöllert <[email protected]>
@mansenfranzen
Copy link
Contributor Author

CLA is signed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants