-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
bpo-31047: Fix ntpath.abspath for invalid paths #8544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request You can check yourself Thanks again for your contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need the NEWS entry - click on the "Details" link for the failed check for info on how to add it. (Your PR title is a good description to put in there.)
Thanks for the advice - added the news entry accordingly. |
Thanks @mansenfranzen for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
GH-8549 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit d2e902e) Co-authored-by: Franz Wöllert <[email protected]>
Sorry, @mansenfranzen and @zooba, I could not cleanly backport this to |
GH-8550 is a backport of this pull request to the 3.6 branch. |
@mansenfranzen I'm assuming you are/were here at the EuroPython sprints and submitted the CLA form already, yes? In any case, the code in the change matches what was provided on the issue tracker by someone who definitely has submitted it, which is why I merged already. |
Yes, filled in the CLA form already. |
(cherry picked from commit d2e902e) Co-authored-by: Franz Wöllert <[email protected]>
CLA is signed now |
Fixes
nt.abspath
for invalid paths to ensureos.path.isabs(os.path.abspath(" ")) == True
to behave the same as for""
or"?"
.Refers to https://bugs.python.org/issue31047
Co-authored-by:
https://bugs.python.org/issue31047