bpo-29894: Deprecate returning an instance of complex subclass from __complex__
#798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_complex__. In a future versions of Python this can be an error.
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @tim-one and @theller to be potential reviewers. |
mdickinson
approved these changes
Mar 24, 2017
| Py_DECREF(tmp); | ||
| return NULL; | ||
| } | ||
| assert(PyFloat_Check(tmp)); |
There was a problem hiding this comment.
Did you intend to include this change in this PR?
There was a problem hiding this comment.
It could be included in bpo-26983, but it was not. This PR is good opportunity to make this change since it is related to complex.__new__.
Do you suggest to exclude this change from the PR and make a separate PR.
There was a problem hiding this comment.
No, the change is fine. I just wasn't sure whether you'd intended to include it as part of this PR or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a future versions of Python this can be an error.