-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-23859: Document that asyncio.wait() does not cancel its futures #7217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike `asyncio.wait_for()`, `asyncio.wait()` does not cancel the passed futures when a timeout accurs.
1st1
approved these changes
May 29, 2018
@1st1: Please replace |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 29, 2018
…ythonGH-7217) Unlike `asyncio.wait_for()`, `asyncio.wait()` does not cancel the passed futures when a timeout accurs. (cherry picked from commit f9aeca2) Co-authored-by: Elvis Pranskevichus <[email protected]>
GH-7227 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 29, 2018
…ythonGH-7217) Unlike `asyncio.wait_for()`, `asyncio.wait()` does not cancel the passed futures when a timeout accurs. (cherry picked from commit f9aeca2) Co-authored-by: Elvis Pranskevichus <[email protected]>
vstinner
reviewed
May 29, 2018
@@ -764,6 +764,9 @@ Task functions | |||
| | futures finish or are cancelled. | | |||
+-----------------------------+----------------------------------------+ | |||
|
|||
Unlike :func:`~asyncio.wait_for`, ``wait()`` will not cancel the futures | |||
when a timeout accurs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: occurs, no?
elprans
added a commit
to elprans/cpython
that referenced
this pull request
May 29, 2018
1st1
pushed a commit
that referenced
this pull request
May 30, 2018
1st1
pushed a commit
that referenced
this pull request
May 30, 2018
…ures (GH-7217) (#7227) * bpo-23859: Document that asyncio.wait() does not cancel its futures (GH-7217) Unlike `asyncio.wait_for()`, `asyncio.wait()` does not cancel the passed futures when a timeout accurs. (cherry picked from commit f9aeca2) Co-authored-by: Elvis Pranskevichus <[email protected]> * Update asyncio-task.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike
asyncio.wait_for()
,asyncio.wait()
does not cancel the passedfutures when a timeout accurs.
https://bugs.python.org/issue23859