Skip to content

bpo-23859: Document that asyncio.wait() does not cancel its futures #7217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2018

Conversation

elprans
Copy link
Contributor

@elprans elprans commented May 29, 2018

Unlike asyncio.wait_for(), asyncio.wait() does not cancel the passed
futures when a timeout accurs.

https://bugs.python.org/issue23859

Unlike `asyncio.wait_for()`, `asyncio.wait()` does not cancel the passed
futures when a timeout accurs.
@bedevere-bot
Copy link

@1st1: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @elprans for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2018
…ythonGH-7217)

Unlike `asyncio.wait_for()`, `asyncio.wait()` does not cancel the passed
futures when a timeout accurs.
(cherry picked from commit f9aeca2)

Co-authored-by: Elvis Pranskevichus <[email protected]>
@bedevere-bot
Copy link

GH-7227 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2018
…ythonGH-7217)

Unlike `asyncio.wait_for()`, `asyncio.wait()` does not cancel the passed
futures when a timeout accurs.
(cherry picked from commit f9aeca2)

Co-authored-by: Elvis Pranskevichus <[email protected]>
@@ -764,6 +764,9 @@ Task functions
| | futures finish or are cancelled. |
+-----------------------------+----------------------------------------+

Unlike :func:`~asyncio.wait_for`, ``wait()`` will not cancel the futures
when a timeout accurs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: occurs, no?

elprans added a commit to elprans/cpython that referenced this pull request May 29, 2018
1st1 pushed a commit that referenced this pull request May 30, 2018
1st1 pushed a commit that referenced this pull request May 30, 2018
…ures (GH-7217) (#7227)

* bpo-23859: Document that asyncio.wait() does not cancel its futures (GH-7217)

Unlike `asyncio.wait_for()`, `asyncio.wait()` does not cancel the passed
futures when a timeout accurs.
(cherry picked from commit f9aeca2)

Co-authored-by: Elvis Pranskevichus <[email protected]>

* Update asyncio-task.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants