bpo-33284 Add to a unit test to improve coverage for numbers.py #6480
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request Thanks again to your contribution and we look forward to looking at it! |
|
Hi, I have signed the CLA. |
|
Hi @londinburgh. While you are all set up on the CLA, the committer (@trevaskis) is not, and @the-knights-who-say-ni requires that all committers and authors on a PR have the CLA signed. |
|
Ok, now all contributors have signed! |
|
Have updated this. |
There was a problem hiding this comment.
Thanks for the patch @londinburgh. I did not test as I think there are 2 little mistakes :)
Also it may be worth adding a NEWs entry?
|
|
||
| @property | ||
| def real(self): | ||
| return self._imag |
There was a problem hiding this comment.
It should be return self._real, right?
|
|
||
| @property | ||
| def imag(self): | ||
| return self._real |
There was a problem hiding this comment.
And same here with self._imag.
|
@londinburgh, please make the changes requested by @BoboTiG. Thanks! |
|
|
||
| @real.setter | ||
| def real(self, value): | ||
| self._real = value |
There was a problem hiding this comment.
These setters would be better placed alongside the getters.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Since this PR is against an unknown repository, I'm going to close it. A new pull request can be opened for the issue, but if it's based on this PR, please credit the original author. |
Small change to improve unit test coverage. My first merge request for python.
https://bugs.python.org/issue33284