Skip to content

bpo-15115: Document deprecation of email.encoders in Python 3 #5354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2019

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Jan 26, 2018

@matrixise
Copy link
Member

@csabella just a News.d file. thanks

@csabella
Copy link
Contributor Author

I didn't think a documentation change would need a blurb entry?

@matrixise
Copy link
Member

@csabella in this case, there is a missing 'skip news' label on this PR

@csabella
Copy link
Contributor Author

csabella commented Feb 1, 2018

@matrixise Yes, I am unable to add labels.

@matrixise matrixise added the docs Documentation in the Doc dir label May 15, 2019
@csabella csabella requested a review from bitdancer May 28, 2019 10:56
@csabella
Copy link
Contributor Author

cc @maxking, please review when you get a chance. Thanks!

@csabella
Copy link
Contributor Author

@maxking, thank you for the review. I've made the requested changes.

@maxking
Copy link
Contributor

maxking commented May 31, 2019

LGTM!

@csabella csabella merged commit a747c3a into python:master May 31, 2019
@csabella csabella deleted the issue15115 branch May 31, 2019 20:18
@csabella
Copy link
Contributor Author

Thank you for the review, @maxking!

@miss-islington
Copy link
Contributor

Thanks @csabella for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-13709 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2019
miss-islington added a commit that referenced this pull request May 31, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants