gh-62824: add alias for iso-8859-8-i and -e to iso_8859_8 #32279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxwellDupre
approved these changes
Apr 23, 2022
Contributor
MaxwellDupre
left a comment
MaxwellDupre
left a comment
There was a problem hiding this comment.
Ran 266 tests in 4.734s
OK (skipped=13)
Looks ok.
arhadthedev
changed the title
Member
|
@malemburg (as an encodings expert) |
Wulian233
approved these changes
Oct 13, 2024
Contributor
|
Will this PR be accepted? Why is it still open? |
Member
|
Yes, I'd accept the PR, but before doing so, the conflicts will have to be resolved and the tests need to finish without errors. |
Contributor
|
Closing in favor of #134306. |
Contributor
Author
Looks like you get quick results your way! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add aliases for iso-8859-8-i and iso-8859-8-e, which is the same as iso-8859-8
Co-authored-by: Ben Galin (bensws)
Source for this PR is derived from a patch submitted by bensws:
https://bugs.python.org/file35736/8859-8_aliases_and_test.patch
https://bugs.python.org/issue18624