Skip to content

[3.9] bpo-46421: Fix unittest filename evaluation when called as a module (GH-30654) #31970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2022
Merged

[3.9] bpo-46421: Fix unittest filename evaluation when called as a module (GH-30654) #31970

merged 2 commits into from
Mar 18, 2022

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 17, 2022 •
edited by bedevere-bot
Loading

(cherry picked from commit a0db11b)

Co-authored-by: Bader Zaidan [email protected]

https://bugs.python.org/issue46421

@bedevere-bot bedevere-bot mentioned this pull request Mar 17, 2022
Merged
4 tasks
@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 17, 2022

@BaderSZ and @JelleZijlstra: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 17, 2022

Sorry, I can't merge this PR. Reason: 2 of 5 required status checks are expected..

@JelleZijlstra JelleZijlstra self-assigned this Mar 17, 2022
@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 18, 2022

@BaderSZ and @JelleZijlstra: Status check is done, and it's a failure ❌ .

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Mar 18, 2022

There's no os_helper in 3.9, will have to look for an alternative.

JelleZijlstra
JelleZijlstra reviewed Mar 18, 2022
View reviewed changes
@JelleZijlstra JelleZijlstra merged commit 1cab44d into python:3.9 Mar 18, 2022
@miss-islington miss-islington deleted the backport-a0db11b-3.9 branch March 18, 2022 03:25
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @BaderSZ @hello-adam
[3.9] bpo-46421: Fix unittest filename evaluation when called as a mo…
86169ce 
…dule (pythonGH-30654) (pythonGH-31970)

(cherry picked from commit a0db11b)

Co-authored-by: Bader Zaidan <[email protected]>
@BaderSZ BaderSZ mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @JelleZijlstra @the-knights-who-say-ni @bedevere-bot @BaderSZ