-
-
Notifications
You must be signed in to change notification settings - Fork 32k
Docstring: replace pysqlite with sqlite3 #31758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings. Also reword the same docstring with "does nothing" to "is a no-op" to align them with the docs.
24bfc2c
to
ab174fb
Compare
@JelleZijlstra: I believe this is one of the rare cases where skip issue can be applied. Please shout out if you disagree. |
We could backport this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. @gvanrossum planning to merge this minor sqlite change
Thanks @erlend-aasland for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
Sorry, @erlend-aasland and @JelleZijlstra, I could not cleanly backport this to |
Sorry @erlend-aasland and @JelleZijlstra, I had trouble checking out the |
I'll backport |
Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings. Also reword "is a no-op" to "does nothing" for clarity.. (cherry picked from commit b33a1ae) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
GH-31777 is a backport of this pull request to the 3.10 branch. |
GH-31778 is a backport of this pull request to the 3.9 branch. |
Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings. Also reword "is a no-op" to "does nothing" for clarity.. (cherry picked from commit b33a1ae) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings. Also reword "is a no-op" to "does nothing" for clarity.
Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings. Also reword "is a no-op" to "does nothing" for clarity.. (cherry picked from commit b33a1ae) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings. Also reword "is a no-op" to "does nothing" for clarity.. (cherry picked from commit b33a1ae) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
…onGH-31778) Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings. Also reword "is a no-op" to "does nothing" for clarity.. (cherry picked from commit b33a1ae) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Replace two instances of "pysqlite" with "sqlite3" in sqlite3 docstrings.
Also align the docs with the docstrings for the two affected methods.