Skip to content

gh-90971: suppress deprecation warning in test_lib2to3 #31464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 13, 2022
Merged

gh-90971: suppress deprecation warning in test_lib2to3 #31464

merged 6 commits into from
Apr 13, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 21, 2022 •
edited by bedevere-bot
Loading

@AlexWaygood AlexWaygood added the tests Tests in the Lib/test dir label Feb 21, 2022
@hugovk
Copy link
Member

hugovk commented Feb 21, 2022

I see this in the CI logs for this PR:

0:04:48 load avg: 5.13 [176/432] test_lib2to3 passed -- running: test_multiprocessing_forkserver (57.4 sec), test_tools (4 min 38 sec), test_gdb (2 min 31 sec)
<string>:2: DeprecationWarning: lib2to3 package is deprecated and may not be able to parse Python 3.10+

https://github.com/python/cpython/runs/5272523879?check_suite_focus=true#step:17:260

@sobolevn
Copy link
Member Author

@hugovk good catch! There was one more warning. Fixed! 👍

hugovk
hugovk approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now no lib2to3 deprecation warnings in the test logs. 👍
https://github.com/python/cpython/runs/5276116883?check_suite_focus=true

@JelleZijlstra JelleZijlstra self-requested a review February 21, 2022 15:59
JelleZijlstra
JelleZijlstra reviewed Feb 21, 2022
View reviewed changes
@JelleZijlstra
Copy link
Member

This should not be backported because 2to3 is only deprecated starting in 3.11.

merwok
merwok reviewed Feb 26, 2022
View reviewed changes
@JelleZijlstra JelleZijlstra changed the title bpo-46815: suppress deprecation warning in test_lib2to3 gh-90971: suppress deprecation warning in test_lib2to3 Apr 13, 2022
JelleZijlstra
JelleZijlstra reviewed Apr 13, 2022
View reviewed changes
@JelleZijlstra JelleZijlstra self-assigned this Apr 13, 2022
@JelleZijlstra JelleZijlstra merged commit 63a0322 into python:main Apr 13, 2022
@sobolevn sobolevn mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok merwok left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@hugovk hugovk hugovk approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sobolevn @hugovk @JelleZijlstra @merwok @the-knights-who-say-ni @bedevere-bot @AlexWaygood