bpo-31234: threading_cleanup() now warns immediately #3138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Aug 19, 2017
Lib/test/support/__init__.py
Outdated
|
|
||
| if not count: | ||
| environment_altered = True | ||
| print("Warning -- threading_cleanup() detected %s leaked threads " |
There was a problem hiding this comment.
I don't like the "leak" terminology here. I think the previous message was better.
There was a problem hiding this comment.
Fixed. I reverted to the original message.
|
I rebased my change to get other fixes for dangling threads and processes. |
vstinner
changed the title
|
test_ftplib and test_poplib should have been fixed by PR #3540. I rebased my PR one more time, only test_ssl should fail. Sadly, I'm unable to reproduce the test_ssl failure. |
vstinner
changed the title
|
I tag again the PR as [WIP] until the test_ssl issue is fixed. I rebased the PR to get the second test_ftplib fix (PR #3544). |
support.threading_cleanup() waits for 1 second before emitting a warning if there are threads running in the background. With this change, it now emits the warning immediately, to be able to catch bugs more easily.
vstinner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support.threading_cleanup() waits for 1 second before emitting a
warning if there are threads running in the background. With this
change, it now emits the warning immediately, to be able to catch
bugs more easily.
https://bugs.python.org/issue31234