Skip to content

bpo-46502: Remove "How do I tell incomplete input" from FAQ #30925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2022
Merged

bpo-46502: Remove "How do I tell incomplete input" from FAQ #30925

merged 2 commits into from
Jan 26, 2022

Conversation

mloskot
Copy link
Contributor

@mloskot mloskot commented Jan 26, 2022

Since,

  • Py_CompileString no longer allows to distinguish "incomplete input"
    from "invalid input"
  • there is no alternative solution available from the Python C API
    due to how the new parser works (rewritten in 3.9)
  • the only supported way is to manually import the codeop module from C
    and use its API as IDLE does, and accept its own complications

it is desirable to remove this Q&A from the official FAQ.


See original report and related discusion at https://bugs.python.org/issue46502

https://bugs.python.org/issue46502

Automerge-Triggered-By: GH:pablogsal

Since,

- Py_CompileString no longer allows to distinguish "incomplete input"
  from "invalid input"
- there is no alternative solution available from the Python C API
  due to how the new parser works (rewritten in 3.9)
- the only supported way is to manually import the codeop module from C
  and use its API as IDLE does, and accept its own complications

it is desirable to remove this Q&A from the official FAQ.
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jan 26, 2022
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@mloskot

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@pablogsal pablogsal added skip news needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jan 26, 2022
@pablogsal
Copy link
Member

Since this is removing code, don't worry about the CLA, but is good if you want to contribute in the future.

@pablogsal
Copy link
Member

Thanks for the PR @mloskot !

@pablogsal pablogsal merged commit f0a6481 into python:main Jan 26, 2022
@miss-islington
Copy link
Contributor

Thanks @mloskot for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @mloskot and @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f0a648152f2d8011f47cc49873438ebaf01d3f82 3.10

@miss-islington
Copy link
Contributor

Sorry @mloskot and @pablogsal, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f0a648152f2d8011f47cc49873438ebaf01d3f82 3.9

pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Jan 26, 2022
…ythonGH-30925)

Since,

- Py_CompileString no longer allows to distinguish "incomplete input"
  from "invalid input"
- there is no alternative solution available from the Python C API
  due to how the new parser works (rewritten in 3.9)
- the only supported way is to manually import the codeop module from C
  and use its API as IDLE does, and accept its own complications

it is desirable to remove this Q&A from the official FAQ..
(cherry picked from commit f0a6481)

Co-authored-by: Mateusz Łoskot <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 26, 2022
@bedevere-bot
Copy link

GH-30933 is a backport of this pull request to the 3.10 branch.

pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Jan 26, 2022
…thonGH-30925)

Since,

- Py_CompileString no longer allows to distinguish "incomplete input"
  from "invalid input"
- there is no alternative solution available from the Python C API
  due to how the new parser works (rewritten in 3.9)
- the only supported way is to manually import the codeop module from C
  and use its API as IDLE does, and accept its own complications

it is desirable to remove this Q&A from the official FAQ..
(cherry picked from commit f0a6481)

Co-authored-by: Mateusz Łoskot <[email protected]>
@bedevere-bot
Copy link

GH-30934 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 26, 2022
pablogsal added a commit that referenced this pull request Jan 27, 2022
…-30925) (GH-30934)

Since,

- Py_CompileString no longer allows to distinguish "incomplete input"
  from "invalid input"
- there is no alternative solution available from the Python C API
  due to how the new parser works (rewritten in 3.9)
- the only supported way is to manually import the codeop module from C
  and use its API as IDLE does, and accept its own complications

it is desirable to remove this Q&A from the official FAQ..
(cherry picked from commit f0a6481)

Co-authored-by: Mateusz Łoskot <[email protected]>

Co-authored-by: Mateusz Łoskot <[email protected]>
pablogsal added a commit that referenced this pull request Jan 27, 2022
…H-30925) (GH-30933)

Since,

- Py_CompileString no longer allows to distinguish "incomplete input"
  from "invalid input"
- there is no alternative solution available from the Python C API
  due to how the new parser works (rewritten in 3.9)
- the only supported way is to manually import the codeop module from C
  and use its API as IDLE does, and accept its own complications

it is desirable to remove this Q&A from the official FAQ..
(cherry picked from commit f0a6481)

Co-authored-by: Mateusz Łoskot <[email protected]>

Co-authored-by: Mateusz Łoskot <[email protected]>
@mloskot mloskot deleted the ml/issue46502-fix-faq branch January 27, 2022 09:19
@mloskot
Copy link
Contributor Author

mloskot commented Jan 27, 2022

Thank you @pablogsal for backporting the changes.

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…thonGH-30925) (pythonGH-30934)

Since,

- Py_CompileString no longer allows to distinguish "incomplete input"
  from "invalid input"
- there is no alternative solution available from the Python C API
  due to how the new parser works (rewritten in 3.9)
- the only supported way is to manually import the codeop module from C
  and use its API as IDLE does, and accept its own complications

it is desirable to remove this Q&A from the official FAQ..
(cherry picked from commit f0a6481)

Co-authored-by: Mateusz Łoskot <[email protected]>

Co-authored-by: Mateusz Łoskot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants