-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
bpo-46502: Remove "How do I tell incomplete input" from FAQ #30925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since, - Py_CompileString no longer allows to distinguish "incomplete input" from "invalid input" - there is no alternative solution available from the Python C API due to how the new parser works (rewritten in 3.9) - the only supported way is to manually import the codeop module from C and use its API as IDLE does, and accept its own complications it is desirable to remove this Q&A from the official FAQ.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Since this is removing code, don't worry about the CLA, but is good if you want to contribute in the future. |
Thanks for the PR @mloskot ! |
Thanks @mloskot for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
Sorry, @mloskot and @pablogsal, I could not cleanly backport this to |
Sorry @mloskot and @pablogsal, I had trouble checking out the |
…ythonGH-30925) Since, - Py_CompileString no longer allows to distinguish "incomplete input" from "invalid input" - there is no alternative solution available from the Python C API due to how the new parser works (rewritten in 3.9) - the only supported way is to manually import the codeop module from C and use its API as IDLE does, and accept its own complications it is desirable to remove this Q&A from the official FAQ.. (cherry picked from commit f0a6481) Co-authored-by: Mateusz Łoskot <[email protected]>
GH-30933 is a backport of this pull request to the 3.10 branch. |
…thonGH-30925) Since, - Py_CompileString no longer allows to distinguish "incomplete input" from "invalid input" - there is no alternative solution available from the Python C API due to how the new parser works (rewritten in 3.9) - the only supported way is to manually import the codeop module from C and use its API as IDLE does, and accept its own complications it is desirable to remove this Q&A from the official FAQ.. (cherry picked from commit f0a6481) Co-authored-by: Mateusz Łoskot <[email protected]>
GH-30934 is a backport of this pull request to the 3.9 branch. |
…-30925) (GH-30934) Since, - Py_CompileString no longer allows to distinguish "incomplete input" from "invalid input" - there is no alternative solution available from the Python C API due to how the new parser works (rewritten in 3.9) - the only supported way is to manually import the codeop module from C and use its API as IDLE does, and accept its own complications it is desirable to remove this Q&A from the official FAQ.. (cherry picked from commit f0a6481) Co-authored-by: Mateusz Łoskot <[email protected]> Co-authored-by: Mateusz Łoskot <[email protected]>
…H-30925) (GH-30933) Since, - Py_CompileString no longer allows to distinguish "incomplete input" from "invalid input" - there is no alternative solution available from the Python C API due to how the new parser works (rewritten in 3.9) - the only supported way is to manually import the codeop module from C and use its API as IDLE does, and accept its own complications it is desirable to remove this Q&A from the official FAQ.. (cherry picked from commit f0a6481) Co-authored-by: Mateusz Łoskot <[email protected]> Co-authored-by: Mateusz Łoskot <[email protected]>
Thank you @pablogsal for backporting the changes. |
…thonGH-30925) (pythonGH-30934) Since, - Py_CompileString no longer allows to distinguish "incomplete input" from "invalid input" - there is no alternative solution available from the Python C API due to how the new parser works (rewritten in 3.9) - the only supported way is to manually import the codeop module from C and use its API as IDLE does, and accept its own complications it is desirable to remove this Q&A from the official FAQ.. (cherry picked from commit f0a6481) Co-authored-by: Mateusz Łoskot <[email protected]> Co-authored-by: Mateusz Łoskot <[email protected]>
Since,
from "invalid input"
due to how the new parser works (rewritten in 3.9)
and use its API as IDLE does, and accept its own complications
it is desirable to remove this Q&A from the official FAQ.
See original report and related discusion at https://bugs.python.org/issue46502
https://bugs.python.org/issue46502
Automerge-Triggered-By: GH:pablogsal