Skip to content

bpo-46417: Debug tp_subclasses crash #30791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bpo-46417: Debug tp_subclasses crash #30791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4138,7 +4138,7 @@ _PyType_GetSubclasses(PyTypeObject *self)
}

// Hold a strong reference to tp_subclasses while iterating on it
PyObject *dict = Py_XNewRef(self->tp_subclasses);
PyObject *dict = self->tp_subclasses;
if (dict == NULL) {
return list;
}
Expand All @@ -4159,7 +4159,6 @@ _PyType_GetSubclasses(PyTypeObject *self)
}
}
done:
Py_DECREF(dict);
return list;
}

Expand Down Expand Up @@ -6568,6 +6567,10 @@ remove_subclass(PyTypeObject *base, PyTypeObject *type)
PyErr_Clear();
}
Py_XDECREF(key);

if (PyDict_Size(dict) == 0) {
Py_CLEAR(base->tp_subclasses);
}
}

static void
Expand Down