Skip to content

bpo-46439: Clarify urllib.request.add_header documentation #30708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

epicfaace
Copy link
Contributor

@epicfaace epicfaace commented Jan 19, 2022

Add note that headers added via urllib.request.add_header are added to redirected requests.

https://bugs.python.org/issue46439

@JelleZijlstra
Copy link
Member

Bots didn't run on this PR, I'm going to close and reopen to see if it helps.

@hugovk
Copy link
Member

hugovk commented Mar 23, 2022

I confirmed the CLA is signed at https://check-python-cla.herokuapp.com/, so I added the label.

Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@orsenthil orsenthil merged commit f348154 into python:main Apr 27, 2022
@miss-islington
Copy link
Contributor

Thanks @epicfaace for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-92004 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed needs backport to 3.10 only security fixes needs backport to 3.9 only security fixes labels Apr 27, 2022
@bedevere-bot
Copy link

GH-92005 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 27, 2022
…o redirected requests (pythonGH-30708)

(cherry picked from commit f348154)

Co-authored-by: Ashwin Ramaswami <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 27, 2022
…o redirected requests (pythonGH-30708)

(cherry picked from commit f348154)

Co-authored-by: Ashwin Ramaswami <[email protected]>
orsenthil pushed a commit that referenced this pull request Apr 27, 2022
…o redirected requests (GH-30708) (#92004)

(cherry picked from commit f348154)

Co-authored-by: Ashwin Ramaswami <[email protected]>

Co-authored-by: Ashwin Ramaswami <[email protected]>
orsenthil pushed a commit that referenced this pull request Apr 27, 2022
…o redirected requests (GH-30708) (#92005)

(cherry picked from commit f348154)

Co-authored-by: Ashwin Ramaswami <[email protected]>

Co-authored-by: Ashwin Ramaswami <[email protected]>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…o redirected requests (pythonGH-30708) (python#92005)

(cherry picked from commit f348154)

Co-authored-by: Ashwin Ramaswami <[email protected]>

Co-authored-by: Ashwin Ramaswami <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants