Skip to content

bpo-45711: Do not push/pop traceback on stack as part of exc_info #29968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

bpo-45711: Do not push/pop traceback on stack as part of exc_info #29968

wants to merge 5 commits into from

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Dec 7, 2021 •
edited by bedevere-bot
Loading

@iritkatriel iritkatriel marked this pull request as draft December 7, 2021 17:47
@iritkatriel
Copy link
Member Author

Marked as draft because I still need to update the opcodes documentation

iritkatriel
iritkatriel commented Dec 7, 2021
View reviewed changes
Python/ceval.c

assert(exc_info->exc_value);
if (exc_info->exc_value != Py_None) {
exc_info->exc_traceback = PyException_GetTraceback(exc_info->exc_value);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next step is to remove exc_traceback from exc_info and then this will not be here.

@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 7, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 98085fe 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 7, 2021
@iritkatriel iritkatriel marked this pull request as ready for review December 7, 2021 18:15
@iritkatriel
Copy link
Member Author

This clashes with the except* branch, and I'd rather merge that one first and update this one.

@markshannon
Copy link
Member

This clashes with the except* branch, and I'd rather merge that one first and update this one.

I would rather merge this first.
Apart from the trivial conflict in dis.rst this seems ready to merge. The except* branch is not.

@iritkatriel
Copy link
Member Author

This clashes with the except* branch, and I'd rather merge that one first and update this one.

I would rather merge this first. Apart from the trivial conflict in dis.rst this seems ready to merge. The except* branch is not.

We won't see a speedup for this because of the get_exc_traceback calls. We should remove them before measuring, and probably merge the whole thing together.

@iritkatriel
Copy link
Member Author

We won't see a speedup for this because of the get_exc_traceback calls. We should remove them before measuring, and probably merge the whole thing together.

And that requires PR 29922.

arhadthedev
arhadthedev requested changes Dec 8, 2021
View reviewed changes
Copy link
Member

@arhadthedev arhadthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing between tokens is strange.

@iritkatriel
Copy link
Member Author

Superseded by #30122

@iritkatriel iritkatriel deleted the 45711-no-traceback-in-stack branch January 13, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev requested changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees
No one assigned
Labels
awaiting core review DO-NOT-MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iritkatriel @bedevere-bot @markshannon @arhadthedev @the-knights-who-say-ni