Skip to content

bpo-40280: Emscripten defaults to --with-ensurepip=no (GH-29873) #29873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2021
Merged

bpo-40280: Emscripten defaults to --with-ensurepip=no (GH-29873) #29873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20268,7 +20268,15 @@ $as_echo_n "checking for ensurepip... " >&6; }
if test "${with_ensurepip+set}" = set; then :
withval=$with_ensurepip;
else
with_ensurepip=upgrade

case $ac_sys_system in #(
Emscripten) :
$with_ensurepip=no ;; #(
*) :
with_ensurepip=upgrade
;;
esac

fi

case $with_ensurepip in #(
Expand Down
7 changes: 6 additions & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5871,7 +5871,12 @@ AC_ARG_WITH(ensurepip,
[AS_HELP_STRING([--with-ensurepip@<:@=install|upgrade|no@:>@],
["install" or "upgrade" using bundled pip (default is upgrade)])],
[],
[with_ensurepip=upgrade])
[
AS_CASE([$ac_sys_system],
[Emscripten], [$with_ensurepip=no],
Copy link
Member

@emmatyping emmatyping Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we disable ensurepip for WASI as well?

Copy link
Member Author

@tiran tiran Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to wait until we have WASI builds working and more experience with WASI.

[with_ensurepip=upgrade]
)
])
AS_CASE($with_ensurepip,
[yes|upgrade],[ENSUREPIP=upgrade],
[install],[ENSUREPIP=install],
Expand Down