Skip to content

bpo-45840: Improve cross-references in the data model documentation #29633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Dec 5, 2021
Merged

bpo-45840: Improve cross-references in the data model documentation #29633

merged 18 commits into from
Dec 5, 2021

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Nov 19, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Nov 19, 2021
merwok
merwok reviewed Nov 19, 2021
View reviewed changes
@merwok merwok added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Nov 20, 2021
@merwok
Copy link
Member

merwok commented Nov 20, 2021 •
edited
Loading

Thank you for the work done here!

I would like to review the changes and look at the results, maybe in the weekend — other core devs can feel free to take over!

serhiy-storchaka
serhiy-storchaka reviewed Nov 29, 2021
View reviewed changes
@serhiy-storchaka serhiy-storchaka merged commit c0521fe into python:main Dec 5, 2021
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @AlexWaygood and @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c0521fe49fd75e794a38a216813658ab40185834 3.10

@miss-islington
Copy link
Contributor

Sorry @AlexWaygood and @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c0521fe49fd75e794a38a216813658ab40185834 3.9

@AlexWaygood AlexWaygood deleted the datamodel-cross-refs branch December 5, 2021 20:55
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Dec 12, 2021
@AlexWaygood
bpo-45840: Improve cross-references in the data model documentation (p…
98e2c21 
…ythonGH-29633)

(cherry picked from commit c0521fe)
@AlexWaygood AlexWaygood mentioned this pull request Dec 12, 2021
Merged
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 12, 2021
@bedevere-bot
Copy link

GH-30077 is a backport of this pull request to the 3.10 branch.

serhiy-storchaka pushed a commit that referenced this pull request Dec 13, 2021
@AlexWaygood
bpo-45840: Improve cross-references in the data model documentation (G…
7da9025 
…H-29633) (GH-30077)

(cherry picked from commit c0521fe)
@AlexWaygood AlexWaygood mentioned this pull request Dec 13, 2021
Merged
@bedevere-bot
Copy link

GH-30081 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Dec 13, 2021
serhiy-storchaka pushed a commit that referenced this pull request Dec 13, 2021
@AlexWaygood
[3.9] bpo-45840: Improve cross-references in the data model document…
2029c58 
…ation (GH-29633) (GH-30081)

Backport of GH-29633 to the 3.9 branch
@AlexWaygood AlexWaygood mentioned this pull request Feb 5, 2022
Open
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok merwok left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AlexWaygood @merwok @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni