bpo-29070: Integration tests for pty module with patch from bpo-26228 #2932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is pty.patch, "test suite v4 including patch for issue26228", 2017-02-09 18:31 http://bugs.python.org/file46613/pty.patch http://bugs.python.org/issue29070
We need to monkey patch the freshly spawned child! Tested that it is actually called by writing to stderr (test code commented out, I don't want to push the verbose flag through all those children).
Awesome idea by Martin Panter!
PtySpawnTestBase (though it does not define any tests) wants to inherit from unittest to have self.fail() available
We don't capture stdin/stdout by running the child and returning what was written once the child is done. We spawn the child and have the pipes available to communicate with the child while it is running.
* remove unrealted code comment * tune documentation * rename function * remove if verbose
Now that code is closer together, we can move up more into the setUp methods.
Better terminology, clearly introducing background/slave.
We still have test_eof. And test_bell_echoctl tests echoctl.
"Also, no documentation string for the method should be included. A comment (such as # Tests function returns only True or False) should be used to provide documentation for test methods. This is done because documentation strings get printed out if they exist and thus what test is being run is not stated." /Doc/build/html/library/test.html
TODO: This branch also includes the patch from Chris Torek bpo-26228.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Fix issue and add huge test suite for pty.py.
Some development of a test suite with integration tests for the pty module happened over several months in the python bug tracker (when python was still on mercurial). Martin Panter already did some awesome review of the code, unfortunately he is currently unavailable and nothing happened in the bug tracker for some months. This is the github pull request of the test suite.
Summary what happened so far:
If this gets merged, we can close two bpo issues and finally have a nice pty test suite, something that is missing for a long time.
Contributors: Patch from Chris Torek [bpo-26228] is included in this pull request! I added him to the ACKS, but I'm not sure if he wants to appear there.
https://bugs.python.org/issue29070