[3.9] bpo-39039: tarfile raises descriptive exception from zlib.error (GH-27766) #28614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pythonGH-27766) * during tarfile parsing, a zlib error indicates invalid data * tarfile.open now raises a descriptive exception from the zlib error * this makes it clear to the user that they may be trying to open a corrupted tar file. (cherry picked from commit b6fe857) Co-authored-by: Jack DeVries <[email protected]>
cool-RR
suggested changes
Sep 29, 2021
| try: | ||
| import zlib | ||
| if isinstance(e, zlib.error): | ||
| raise ReadError(f'zlib error: {e}') |
There was a problem hiding this comment.
Shouldn't this have from e at the end?
There was a problem hiding this comment.
Please read the description of the backport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corrupted tar file.
(cherry picked from commit b6fe857)
Note: since BPO-39717 wasn't backported to 3.9, this backport PR doesn't use
from Nonein the newraisestatement either.Co-authored-by: Jack DeVries [email protected]
https://bugs.python.org/issue39039