bpo-20803: doc: clarify that struct.pack_into writes 0x00 for pad bytes #28047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 30 days with no activity. |
ambv
reviewed
Oct 5, 2021
Comment on lines
+63
to
+64
| .. note:: | ||
| 'x' padding inserts null bytes to pad bytes. |
There was a problem hiding this comment.
Please add this as a footnote to the Format characters table instead. The pad byte is the first one listed there.
|
@DonnaDia Could you address the review please? |
github-actions
bot
removed
the
stale
|
I'll clone this PR into a new one to address the comments, but let me know if you'd still like to work on it. |
|
See #98635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue20803