Fix missing spaces with help for -m compileall -o, revisit
#27591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
changed the title
-m compileall -o-m compileall -o, revisit
ambv
reviewed
Aug 4, 2021
Lib/compileall.py
Outdated
Contributor
There was a problem hiding this comment.
Maybe fix the dest= here too to be singular.
Contributor
Author
There was a problem hiding this comment.
It is actually a list.
I've fixed the fixup.
Contributor
|
An issue and NEWS entry would be nice to have as well. |
blueyed
commented
Aug 5, 2021
Contributor
Author
blueyed
left a comment
blueyed
left a comment
There was a problem hiding this comment.
An issue and NEWS entry would be nice to have as well.
I do not think it is worth it, but can add it if required really, of course.
Lib/compileall.py
Outdated
Contributor
Author
There was a problem hiding this comment.
It is actually a list.
I've fixed the fixup.
serhiy-storchaka
approved these changes
Aug 25, 2021
serhiy-storchaka
added
needs backport to 3.9
needs backport to 3.10
Member
|
Documentation fixes usually do not need a NEWS entry. |
blueyed
force-pushed
the
fix-compileall-help-space
branch
from
4408132 to
426245c
Compare
Contributor
|
GH-28430 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 17, 2021
(cherry picked from commit 74cc245) Co-authored-by: Daniel Hahler <[email protected]>
|
GH-28431 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 17, 2021
(cherry picked from commit 74cc245) Co-authored-by: Daniel Hahler <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Sep 17, 2021
(cherry picked from commit 74cc245) Co-authored-by: Daniel Hahler <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Sep 17, 2021
(cherry picked from commit 74cc245) Co-authored-by: Daniel Hahler <[email protected]>
niyas-sait
pushed a commit
to niyas-sait/cpython
that referenced
this pull request
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.