bpo-44734: Fix precision in turtle tests #27343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFY00
approved these changes
Jul 25, 2021
There was a problem hiding this comment.
While we are here, I suggest to inline values of vec and expected variables and remove empty lines between asserts in this method. The body of test_distance will reduce from 11 lines to 3 lines, that is more readable, and the traceback will contain more useful information.
loganasherjones
force-pushed
the
issue-44734
branch
from
0b44f86 to
8ced094
Compare
|
Thanks for the review @serhiy-storchaka I made the changes you requested. Let me know if there's anything else! |
serhiy-storchaka
added
needs backport to 3.9
loganasherjones
force-pushed
the
issue-44734
branch
from
8ced094 to
be8c911
Compare
|
Thanks @loganasherjones for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
|
GH-27361 is a backport of this pull request to the 3.10 branch. |
|
GH-27362 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 26, 2021
(cherry picked from commit 3f135c0) Co-authored-by: Logan Jones <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 26, 2021
(cherry picked from commit 3f135c0) Co-authored-by: Logan Jones <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Jul 26, 2021
(cherry picked from commit 3f135c0) Co-authored-by: Logan Jones <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Jul 26, 2021
(cherry picked from commit 3f135c0) Co-authored-by: Logan Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue44734