bpo-38291: Fix a deprecation warning in typing tests #27312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was accessing typing.{io,re}.__all__, which triggered the
warning. This check isn't necessary anymore, since the objects from
typing.{io,re}.__all__ are in typing.__all__ as well, since Python 3.10.
|
Aside: I could not reproduce the warning when running the tests locally. |
JelleZijlstra
approved these changes
Jul 23, 2021
gvanrossum
approved these changes
Jul 23, 2021
|
@gvanrossum: Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was accessing typing.{io,re}.all, which triggered the
warning. This check isn't necessary anymore, since the objects from
typing.{io,re}.all are in typing.all as well, since Python 3.10.
A NEWS should not be required, since this affects the tests only.
Cc @serhiy-storchaka
https://bugs.python.org/issue38291