bpo-40928: notify users of osx malloc warnings #26783
Conversation
* When trying to allocate very large regions on OS X, malloc does not fail silently. It sends a very noisy error out to STDERR * This provides a helper function to warn the user, and provides the warning for test_decimal, which consistently generates these warnings on my mac.
|
This PR is stale because it has been open for 30 days with no activity. |
ambv
left a comment
ambv
left a comment
There was a problem hiding this comment.
This is a safe change to introduce regardless of what we do with the root cause.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @ambv: please review the changes made to this pull request. |
github-actions
bot
removed
the
stale
|
Thanks @jdevries3133 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Thanks @jdevries3133 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Sorry @jdevries3133 and @ambv, I had trouble checking out the |
…ngs (pythonGH-26783) * When trying to allocate very large regions on macOS, malloc does not fail silently. It sends a noisy error out to STDERR * This provides a helper function to warn the user, and provides the warning for test_decimal, which consistently generates these warnings on macOS. Co-authored-by: Łukasz Langa <[email protected]> (cherry picked from commit 15d3c14) Co-authored-by: Jack DeVries <[email protected]>
|
GH-27628 is a backport of this pull request to the 3.10 branch. |
|
Thanks @jdevries3133 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Sorry, @jdevries3133 and @ambv, I could not cleanly backport this to |
… warnings (pythonGH-26783) * When trying to allocate very large regions on macOS, malloc does not fail silently. It sends a noisy error out to STDERR * This provides a helper function to warn the user, and provides the warning for test_decimal, which consistently generates these warnings on macOS. Co-authored-by: Łukasz Langa <[email protected]>. (cherry picked from commit 15d3c14) Co-authored-by: Jack DeVries <[email protected]>
|
GH-27629 is a backport of this pull request to the 3.9 branch. |
… warnings (GH-26783) (GH-27629) * When trying to allocate very large regions on macOS, malloc does not fail silently. It sends a noisy error out to STDERR * This provides a helper function to warn the user, and provides the warning for test_decimal, which consistently generates these warnings on macOS. Co-authored-by: Łukasz Langa <[email protected]>. (cherry picked from commit 15d3c14) Co-authored-by: Jack DeVries <[email protected]>
…ngs (GH-26783) * When trying to allocate very large regions on macOS, malloc does not fail silently. It sends a noisy error out to STDERR * This provides a helper function to warn the user, and provides the warning for test_decimal, which consistently generates these warnings on macOS. Co-authored-by: Łukasz Langa <[email protected]> (cherry picked from commit 15d3c14) Co-authored-by: Jack DeVries <[email protected]>
5 participants
This is a bandaid to help people save time debugging this non-bug. I don't think this solution is very strong; I'm just hoping to move the discussion forward on the bpo, and hoping for a hint on how to suppress these warnings all together or come up with some other optimal solution.
I applied the function in test_decimal because that test consistently generates these malloc warnings on my system.
https://bugs.python.org/issue40928