Skip to content

Reorganize test_patma.py #26661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2021
Merged

Reorganize test_patma.py #26661

merged 1 commit into from
Jun 18, 2021

Conversation

brandtbucher
Copy link
Member

The diff is a bit noisy, but this doesn't actually change much. These tests just needed a bit more structure.

Mainly, this moves all of the tests checking for errors into their own classes and gives them meaningful names. It also re-numbers the remaining tests, removes some unused imports, and refactors the perf script at the bottom.

@brandtbucher brandtbucher added tests Tests in the Lib/test dir skip issue skip news needs backport to 3.10 only security fixes labels Jun 10, 2021
@brandtbucher
Copy link
Member Author

The x86 Windows failure looks unrelated:

======================================================================
FAIL: test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.ProactorEventLoopTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_asyncio\test_sendfile.py", line 457, in test_sendfile_close_peer_in_the_middle_of_receiving
    with self.assertRaises(ConnectionError):
AssertionError: ConnectionError not raised

----------------------------------------------------------------------

@brandtbucher brandtbucher merged commit c106cf3 into python:main Jun 18, 2021
@miss-islington
Copy link
Contributor

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2021
@brandtbucher @miss-islington
Reorganize the pattern matching suite (pythonGH-26661)
8d4573e 
(cherry picked from commit c106cf3)

Co-authored-by: Brandt Bucher <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 18, 2021
@bedevere-bot
Copy link

GH-26787 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Jun 18, 2021
@miss-islington
[3.10] Reorganize the pattern matching suite (GH-26661) (GH-26787)
bba7267 
(cherry picked from commit c106cf3)


Co-authored-by: Brandt Bucher <[email protected]>

Automerge-Triggered-By: GH:brandtbucher
jdevries3133 pushed a commit to jdevries3133/cpython that referenced this pull request Jun 19, 2021
@brandtbucher @jdevries3133
Reorganize the pattern matching suite (pythonGH-26661)
95aa9d6
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@brandtbucher brandtbucher deleted the reorganize-test-patma branch July 21, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandtbucher @miss-islington @bedevere-bot @the-knights-who-say-ni