Skip to content

[3.10] bpo-44295: ensure deprecation warning from assertDictContainsSubset points at actual test code #26497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2021
Merged

[3.10] bpo-44295: ensure deprecation warning from assertDictContainsSubset points at actual test code #26497

merged 1 commit into from
Nov 16, 2021

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Jun 2, 2021 •
edited by bedevere-bot
Loading

@github-actions
Copy link

github-actions bot commented Jul 3, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 3, 2021
graingert
graingert reviewed Jul 3, 2021
View reviewed changes
@asottile asottile changed the base branch from main to 3.10 November 2, 2021 02:26
@asottile asottile force-pushed the assertDictContainsSubset_stacklevel_bpo-44295 branch from c4c4807 to 939f585 Compare November 2, 2021 02:27
@asottile asottile changed the title bpo-44295: ensure deprecation warning from assertDictContainsSubset points at actual test code [3.10] bpo-44295: ensure deprecation warning from assertDictContainsSubset points at actual test code Nov 2, 2021
@asottile
Copy link
Contributor Author

asottile commented Nov 2, 2021

apologies for the CC spam -- I changed the target branch from main to 3.10 since this function was removed on main (but the bug is still present in older versions)

@vsajip vsajip removed request for a team, vsajip and tiran November 2, 2021 13:41
@vsajip
Copy link
Member

vsajip commented Nov 2, 2021

Eh? I only removed myself, not the teams and not @tiran !

@rhettinger rhettinger merged commit 7c99e43 into python:3.10 Nov 16, 2021
@bedevere-bot
Copy link

@rhettinger: Please replace # with GH- in the commit message next time. Thanks!

@asottile asottile deleted the assertDictContainsSubset_stacklevel_bpo-44295 branch November 16, 2021 03:13
@gvanrossum gvanrossum removed their request for review November 16, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graingert graingert graingert approved these changes

@rhettinger rhettinger rhettinger approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

@cjw296 cjw296 Awaiting requested review from cjw296

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

@ethanfurman ethanfurman Awaiting requested review from ethanfurman

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@isidentical isidentical Awaiting requested review from isidentical

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

@markshannon markshannon Awaiting requested review from markshannon

@methane methane Awaiting requested review from methane

@pablogsal pablogsal Awaiting requested review from pablogsal

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees
No one assigned
Labels
stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@asottile @vsajip @bedevere-bot @graingert @rhettinger @the-knights-who-say-ni