Skip to content

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented May 27, 2021

  • Bump version of importlib_metadata included.
  • Add note about compatibility notice and fix link to entry_points documentation.
  • Add note about removal of access by index on Distribution.entry_points.

https://bugs.python.org/issue44246

Automerge-Triggered-By: GH:jaraco

Bump version of importlib_metadata included.
Add note about compatibility notice and fix link to entry_points documentation.
Add note about removal of access by index on Distribution.entry_points.
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this reads well. I just have one minor suggestion below to fix the doc build errors.

@jaraco
Copy link
Member Author

jaraco commented May 27, 2021

The link to entry_points isn't working:
image

I need to figure out what the right incantation is to link to that anchor.

@jaraco jaraco merged commit 28f12c9 into main May 27, 2021
@jaraco jaraco deleted the bpo-44246/refresh-importlib-metadata-whatsnew branch May 27, 2021 23:36
@miss-islington
Copy link
Contributor

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@jaraco: Please replace # with GH- in the commit message next time. Thanks!

@bedevere-bot
Copy link

GH-26415 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 27, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2021
* bpo-44246: Update What's New for importlib.metadata.

Bump version of importlib_metadata included.
Add note about compatibility notice and fix link to entry_points documentation.
Add note about removal of access by index on Distribution.entry_points.

* Fix syntax mistake in issue reference.

Co-authored-by: Ken Jin <[email protected]>

* Fix broken reference in entry-points.

Co-authored-by: Ken Jin <[email protected]>
(cherry picked from commit 28f12c9)

Co-authored-by: Jason R. Coombs <[email protected]>
miss-islington added a commit that referenced this pull request May 27, 2021
GH-26415)

* [bpo-44246](): Update What's New for importlib.metadata.

Bump version of importlib_metadata included.
Add note about compatibility notice and fix link to entry_points documentation.
Add note about removal of access by index on Distribution.entry_points.

* Fix syntax mistake in issue reference.

Co-authored-by: Ken Jin <[email protected]>

* Fix broken reference in entry-points.

Co-authored-by: Ken Jin <[email protected]>
(cherry picked from commit 28f12c9)


Co-authored-by: Jason R. Coombs <[email protected]>

Automerge-Triggered-By: GH:jaraco
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants