Skip to content

bpo-43504: Remove effbot urls #26308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2021
Merged

Conversation

E-Paine
Copy link
Contributor

@E-Paine E-Paine commented May 22, 2021

Note: I have changed the reference in Objects/stringlib/fastsearch.h to the Wayback machine because (IMO) this content is still required.

Note: I have not changed the XML tests where effbot is used as a namespace.

https://bugs.python.org/issue43504

@JulienPalard
Copy link
Member

Thanks @E-Paine !

@E-Paine E-Paine deleted the remove-effbot-urls branch May 22, 2021 12:11
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Non-Debug with X 3.x has failed when building commit e9f66ae.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/58/builds/238) and take a look at the build logs.
  4. Check if the failure is related to this commit (e9f66ae) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/58/builds/238

Failed tests:

  • test_idle

Failed subtests:

  • test_incremental_editing - idlelib.idle_test.test_colorizer.ColorDelegatorTest

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

416 tests OK.

10 slowest tests:

  • test_peg_generator: 13 min 9 sec
  • test_concurrent_futures: 3 min 58 sec
  • test_unparse: 3 min 22 sec
  • test_tokenize: 3 min 4 sec
  • test_asyncio: 2 min 32 sec
  • test_lib2to3: 2 min 29 sec
  • test_multiprocessing_spawn: 2 min 25 sec
  • test_multiprocessing_forkserver: 1 min 19 sec
  • test_pickle: 1 min 4 sec
  • test_multiprocessing_fork: 1 min 4 sec

1 test failed:
test_idle

10 tests skipped:
test_ctypes test_devpoll test_ioctl test_kqueue test_msilib
test_startfile test_winconsoleio test_winreg test_winsound
test_zipfile64

1 re-run test:
test_idle

Total duration: 33 min 59 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/idlelib/idle_test/tkinter_testing_utils.py", line 54, in new_test_method
    raise exception
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/idlelib/idle_test/tkinter_testing_utils.py", line 38, in after_callback
    next(test_generator)
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/idlelib/idle_test/test_colorizer.py", line 569, in test_incremental_editing
    eq(text.tag_nextrange('KEYWORD', '1.0'), ('1.0', '1.2'))
AssertionError: Tuples differ: () != ('1.0', '1.2')


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/idlelib/idle_test/tkinter_testing_utils.py", line 54, in new_test_method
    raise exception
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/idlelib/idle_test/tkinter_testing_utils.py", line 38, in after_callback
    next(test_generator)
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/idlelib/idle_test/test_colorizer.py", line 578, in test_incremental_editing
    eq(text.tag_nextrange('BUILTIN', '1.0'), ())
AssertionError: Tuples differ: ('1.0', '1.3') != ()

@E-Paine
Copy link
Contributor Author

E-Paine commented May 22, 2021

This PR cannot have caused these failures, so they are safe to ignore (it's just IDLE)

@miss-islington
Copy link
Contributor

Thanks @E-Paine for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @E-Paine for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @E-Paine and @JulienPalard, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e9f66aedf44ccc3be27975cfb070a44ce6a6bd13 3.9

@miss-islington
Copy link
Contributor

Sorry @E-Paine and @JulienPalard, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e9f66aedf44ccc3be27975cfb070a44ce6a6bd13 3.10

@JelleZijlstra JelleZijlstra self-requested a review May 2, 2022 15:34
@JelleZijlstra
Copy link
Member

I'm working with a contributor at the sprints to get this fixed in 3.9 and 3.10.

pr-watson pushed a commit to pr-watson/cpython that referenced this pull request May 2, 2022
(cherry picked from commit e9f66ae)

Co-authored-by: E-Paine <[email protected]>
@JelleZijlstra JelleZijlstra removed their request for review May 2, 2022 15:55
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 2, 2022
@bedevere-bot
Copy link

GH-92161 is a backport of this pull request to the 3.10 branch.

pr-watson pushed a commit to pr-watson/cpython that referenced this pull request May 2, 2022
(cherry picked from commit e9f66ae)

Co-authored-by: E-Paine <[email protected]>
@bedevere-bot
Copy link

GH-92162 is a backport of this pull request to the 3.9 branch.

JelleZijlstra pushed a commit that referenced this pull request May 2, 2022
* [3.10] Remove effbot urls (GH-26308).
(cherry picked from commit e9f66ae)

Co-authored-by: E-Paine <[email protected]>
JelleZijlstra pushed a commit that referenced this pull request May 2, 2022
(cherry picked from commit e9f66ae)

Co-authored-by: E-Paine <[email protected]>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants