Skip to content

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented May 1, 2021

@pablogsal pablogsal requested a review from a team as a code owner May 1, 2021 01:02
@pablogsal pablogsal requested a review from vstinner May 1, 2021 01:04
@pablogsal pablogsal merged commit 558df90 into python:master May 1, 2021
@pablogsal pablogsal deleted the bpo-43916 branch May 1, 2021 01:21
@vstinner
Copy link
Member

vstinner commented May 1, 2021

Why did you add the function to Doc/data/stable_abi.dat? It's excluded from the limited C API, it's only part of the internal C API.

@pablogsal
Copy link
Member Author

Why did you add the function to Doc/data/stable_abi.dat? It's excluded from the limited C API, it's only part of the internal C API.

If you don't export it it won't be usable from the extension modules IIRC. The CI was failing if I just export it and I don't add it to the stable_abi file.

If you have a better way to structure it so is not exported, please go ahead and fix it.

@pablogsal
Copy link
Member Author

Why did you add the function to Doc/data/stable_abi.dat? It's excluded from the limited C API, it's only part of the internal C API.

See #25854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants