Skip to content

bpo-31870: Fix test_get_server_certificate_timeout on Windows (GH-25570) #25570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2021
Merged

bpo-31870: Fix test_get_server_certificate_timeout on Windows (GH-25570) #25570

merged 1 commit into from
Apr 24, 2021

Conversation

tiran
Copy link
Member

@tiran tiran commented Apr 24, 2021 •
edited by bedevere-bot
Loading

Some OS do not support millisecond granularity in select(). Use 100ms
timeout and a server callback with sleep to emulate a slow server.

https://bugs.python.org/issue31870

@tiran
bpo-31870: Fix test_get_server_certificate_timeout on Windows
9f1c20f 
Some OS do not support millisecond granularity in select(). Use 100ms
timeout and a server callback with sleep to emulate a slow server.
@tiran tiran added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Apr 24, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 9f1c20f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 24, 2021
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Apr 24, 2021
@tiran tiran mentioned this pull request Apr 24, 2021
Merged
@tiran tiran changed the title bpo-31870: Fix test_get_server_certificate_timeout on Windows bpo-31870: Fix test_get_server_certificate_timeout on Windows (GH-25570) Apr 24, 2021
@tiran tiran merged commit f05c2ae into python:master Apr 24, 2021
@tiran tiran deleted the bpo-31870-ssl-timeout branch April 24, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiran @bedevere-bot @the-knights-who-say-ni