Skip to content

Commit f05c2ae

Browse files
authored
bpo-31870: Fix test_get_server_certificate_timeout on Windows (GH-25570)
Some OS do not support millisecond granularity in select(). Use 100ms timeout and a server callback with sleep to emulate a slow server.
1 parent b2fac1a commit f05c2ae

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

Lib/test/test_ssl.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2137,9 +2137,13 @@ def test_get_server_certificate_fail(self):
21372137
_test_get_server_certificate_fail(self, *self.server_addr)
21382138

21392139
def test_get_server_certificate_timeout(self):
2140+
def servername_cb(ssl_sock, server_name, initial_context):
2141+
time.sleep(0.2)
2142+
self.server_context.set_servername_callback(servername_cb)
2143+
21402144
with self.assertRaises(socket.timeout):
21412145
ssl.get_server_certificate(self.server_addr, ca_certs=SIGNING_CA,
2142-
timeout=0.0001)
2146+
timeout=0.1)
21432147

21442148
def test_ciphers(self):
21452149
with test_wrap_socket(socket.socket(socket.AF_INET),

0 commit comments

Comments
 (0)