-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-43207: InspectLoader.is_package is not an abstract method #24517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
This PR is stale because it has been open for 30 days with no activity. |
@FFY00 Thank you for your approval, could you teach me what else is needed to push through this change? |
We need a core dev to merge this, and that is often hard as there is too much to do and too little time 😅 @jaraco would you be able to take a look when you have a moment? |
Looking at the report, this issue has been around since Python 3.4, so I'm backporting it to all Pythons receiving bug fixes. |
Thanks @Isa-rentacs for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
…GH-24517) Making the description of `InspectLoader.is_package` aligned with the current implementation. Automerge-Triggered-By: GH:jaraco (cherry picked from commit 8b9310d) Co-authored-by: Junnosuke Kuroda <[email protected]>
GH-26321 is a backport of this pull request to the 3.10 branch. |
GH-26322 is a backport of this pull request to the 3.9 branch. |
…GH-24517) Making the description of `InspectLoader.is_package` aligned with the current implementation. Automerge-Triggered-By: GH:jaraco (cherry picked from commit 8b9310d) Co-authored-by: Junnosuke Kuroda <[email protected]>
Making the description of `InspectLoader.is_package` aligned with the current implementation. Automerge-Triggered-By: GH:jaraco (cherry picked from commit 8b9310d) Co-authored-by: Junnosuke Kuroda <[email protected]>
…) (#26322) Making the description of `InspectLoader.is_package` aligned with the current implementation. Automerge-Triggered-By: GH:jaraco (cherry picked from commit 8b9310d) Co-authored-by: Junnosuke Kuroda <[email protected]>
Making the description of
InspectLoader.is_package
aligned with the current implementation.https://bugs.python.org/issue43207
Automerge-Triggered-By: GH:jaraco